Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary diagLevel fhicl parameter #163

Open
AndrewEdmonds11 opened this issue Jun 17, 2024 · 1 comment
Open

Remove unnecessary diagLevel fhicl parameter #163

AndrewEdmonds11 opened this issue Jun 17, 2024 · 1 comment
Assignees
@AndrewEdmonds11
Labels
art / Offline This requires some touching of art / Offline enhancement New feature or request good first issue Good for newcomers
Milestone
Future release

Comments

@AndrewEdmonds11
Copy link
Collaborator

At the moment, we have different ways of telling the art module to write out lower-level objects:

  • diagLevel for straw hits
  • FillCrvRecoPulses for the CRV

We should standardize this
@AndrewEdmonds11 AndrewEdmonds11 added enhancement New feature or request more discussion needed More discussion is needed on this issue art / Offline This requires some touching of art / Offline labels Jun 17, 2024
@AndrewEdmonds11
Copy link
Collaborator Author

Looking at the code, we already have a fillHitInfo parameter for straw hits. I think the diagLevel parameter can be safely removed. This is a good first issue. Whoever picks this up should make sure all the commonly-used fcl files work.

@AndrewEdmonds11 AndrewEdmonds11 changed the title Standardize fhicl parameters for adding lower-level objects Remove unnecesary diagLevel fhicl parameter Jul 19, 2024
@AndrewEdmonds11 AndrewEdmonds11 added good first issue Good for newcomers and removed more discussion needed More discussion is needed on this issue labels Jul 19, 2024
@AndrewEdmonds11 AndrewEdmonds11 changed the title Remove unnecesary diagLevel fhicl parameter Remove unnecessary diagLevel fhicl parameter Jul 19, 2024
@AndrewEdmonds11 AndrewEdmonds11 added this to the Future release milestone Sep 3, 2024
@AndrewEdmonds11 AndrewEdmonds11 self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewEdmonds11 AndrewEdmonds11

Labels
art / Offline This requires some touching of art / Offline enhancement New feature or request good first issue Good for newcomers
Projects
Mu2e Ntuple
Status: In progress
Milestone
Future release
Development

No branches or pull requests
1 participant
@AndrewEdmonds11