Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support "test with" for mu2e_trig_config #124

Open
kutschke opened this issue Sep 9, 2024 · 0 comments
Open

Properly support "test with" for mu2e_trig_config #124

kutschke opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kutschke
Copy link
Collaborator

kutschke commented Sep 9, 2024

Maybe this issue may require fixes in both this repo and Mu2e/codetools . I am not sure.

If you use the CI "test with" clause that includes a PR from mu2e_trig_config, it will work correctly but will generate an error message saying that there is no branch specified for the merge. It will then default to merging into HEAD, which is correct so long as we do not have other working branches in that repo. That is true for now but will not be in the medium term. For an example see:

Mu2e/Offline#1333 (comment)

The issue is to update the code in either CI and/or codetools to get the requested branch name and pass it to the section of codetools that uses it.

@kutschke kutschke added the enhancement New feature or request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant