Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for constraint_append not null constraints #100

Open
MrPowers opened this issue Mar 11, 2023 · 5 comments
Open

Add unit tests for constraint_append not null constraints #100

MrPowers opened this issue Mar 11, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@MrPowers
Copy link
Owner

Make sure the constraint_append function works well for NOT NULL constraints in the test suite.

See this blog post for more on NOT NULL constraints: https://delta.io/blog/2022-11-21-delta-lake-contraints-check/

@cs23andris
Copy link
Contributor

I'd be happy to add these tests, can you assign it to me please?

@robertkossendey
Copy link
Collaborator

@cs23andris Great, assigned you!

@cs23andris
Copy link
Contributor

Unfortunately, NOT NULL constraints are not checked in the current implementation of the constraint_append function, because they're not stored as delta table properties but with the table schema. I think it'd be nice to extend the constraint_append to check for the nullability of columns as well. Can I proceed with that in this issue?

@robertkossendey
Copy link
Collaborator

Sounds good and thank you @cs23andris, feel free to work on this! :)

@MrPowers
Copy link
Owner Author

Awesome, glad we have unit tests to check the edge cases. Thanks for working on this one @cs23andris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants