Hide position indicator on layer 'mouseout' #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
fbonzon
reviewed
May 7, 2018
| @@ -669,6 +669,7 @@ L.Control.Elevation = L.Control.extend({ | |||
| } | |||
| if (layer) { | |||
| layer.on("mousemove", this._handleLayerMouseOver.bind(this)); | |||
| layer.on("mouseout", this._hidePositionMarker.bind(this)); | |||
There was a problem hiding this comment.
There is a problem if the elevation profile is removed from the Leaflet map. The layer would still have listeners pointing to an elevation profile that no longer exists. I think we should take care of removing listeners too.
Try this. Here, change lines 670-673 to:
if (layer) {
this._layer = layer;
layer.on("mousemove", this._handleLayerMouseOver, this).
on("mouseout", this._hidePositionMarker, this);
}And add in onRemove at top of file:
if (this._layer) {
this._layer.off("mousemove", this._handleLayerMouseOver, this).
off("mouseout", this._hidePositionMarker, this);
}There was a problem hiding this comment.
Good point. I guess in theory addData could be called multiple times, so we would need to keep a list of layers. clear should probably also remove listeners.
I won't update this right now, maybe later. Feel free to share an alternative PR and I'll close mine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position indicator/marker on the diagram remains at last position after hovering over the data layer on the map. This adds a mouseout listener to the layer to remove the diagram indicator.