Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot drag skill icon to skill bar on mobile #429

Open
ledenis opened this issue Jul 19, 2024 · 2 comments
Open

Cannot drag skill icon to skill bar on mobile #429

ledenis opened this issue Jul 19, 2024 · 2 comments
Labels
Bug Something that is already regarded as completed not working how it should be.

Comments

@ledenis
Copy link
Contributor

ledenis commented Jul 19, 2024

Describe the bug

  1. Open robrowser on mobile
  2. Open the skill list
  3. Try to drag any skill (e.g. First Aid) (by starting the drag from the icon) to the skill bar.

Actual behavior: Skill is not dragged
Expected: Skill should be dragged

Packet/Client version
Tested with packetver 20130618 and 20131223

Browser/device info

  • Browser: Chrome Android 120
  • Device: Samsung Galaxy A52

Additional context
We can drag items however, not skills.

@ledenis ledenis added the Bug Something that is already regarded as completed not working how it should be. label Jul 19, 2024
@MrAntares
Copy link
Owner

Yes, this is a known issue. Chrome on android doesn't respect the drag method we use. Funny thing is that Samsung Browser, which is also chromium based does work, only the image is not shown when draggind and you only can see the code being dragged. The whole drag system needs a redo for touch.

@ledenis
Copy link
Contributor Author

ledenis commented Jul 21, 2024

Actually, I discovered this:

  • drag from the skill name (a.g. "First Aid Lv : 1"): OK
  • drag from the skill cost (e.g. "Sp: 3"): OK
  • drag from the skill icon: KO

(I will update the issue description to reflect that)

I investigated and found out that Chrome Android does not (yet) support dragging <img> elements (see issue: https://issues.chromium.org/issues/40136077, reason is it would conflict with the context menu)

Indeed the skill list uses <img> to render the icon.

I can confirm this by comparing with other draggable icons:

  • drag from skill bar icons: OK: uses <div style="background-image">
  • drag from inventory items icons: OK: uses <div style="background-image">
  • drag from NPC shop items icons: OK: uses <div style="background-image">
  • drag from skill list icons: KO: uses <img>

So, a possible fix is to also use <div style="background-image"> instead of <img> to render the skill list icons?

@ledenis ledenis changed the title Cannot drag skill to skill bar on mobile Cannot drag skill icon to skill bar on mobile Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that is already regarded as completed not working how it should be.
Projects
None yet
Development

No branches or pull requests

2 participants