Upgrade 1.11.0 #45
Merged
Upgrade 1.11.0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
approved these changes
May 20, 2024
tmpolaczyk
reviewed
May 20, 2024
| @@ -444,7 +470,7 @@ pub fn start_instant_seal_node(config: Configuration) -> Result<TaskManager, sc_ | |||
| transaction_pool: Some(OffchainTransactionPoolFactory::new( | |||
| transaction_pool.clone(), | |||
| )), | |||
| network_provider: network.clone(), | |||
| network_provider: Arc::new(network.clone()), | |||
There was a problem hiding this comment.
This looks wrong but I see polkadot-sdk also does it...
There was a problem hiding this comment.
yeah the compiler did not complaint about it, why do you think is wrong?
There was a problem hiding this comment.
If network is already an Arc, then this is like having an Arc<Arc<T>>, it works but it doesn't make sense.
tmpolaczyk
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.