Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ordering and metric logic in Perfume parser #384

Open
GoogleCodeExporter opened this issue May 4, 2015 · 0 comments
Open

Separate ordering and metric logic in Perfume parser #384

GoogleCodeExporter opened this issue May 4, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

We should extend the parser (for Perfume only) to separate the ordering and 
metric logic.

Previously, TIME capture groups were used for metrics that also included 
ordering information (like time does), so log lines were reordered into a 
monotonically-increasing order. Currently, log lines are never reordered: 
line-based ordering is always used.

We should allow users to specify ordering via TIME groups (which may become 
more sensible if they are renamed ORDER groups) and independently specify 
metrics in new groups (e.g., IMETRIC, DMETRIC, FMETRIC). Going forward, here is 
how Perfume should respond when users do or don't specify different group types:

If no order group and no metric group:
-- fail (we don't have a way to identify metric)

If order group and no metric group:
-- use order group for both the ordering and for metric

If no order group but have a metric group:
-- use line-based ordering and metric group for metric (this is currently the 
only option in Perfume)

If both order group and metric group:
-- use order group for ordering and metric group for metric

Original issue reported on code.google.com by [email protected] on 13 Aug 2014 at 3:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant