Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function 'function' field is dict instead of str #186

Open
kmantel opened this issue Jan 11, 2022 · 4 comments
Open

Function 'function' field is dict instead of str #186

kmantel opened this issue Jan 11, 2022 · 4 comments

Comments

@kmantel
Copy link
Contributor

kmantel commented Jan 11, 2022

Since d1f4937, the 'function' field of Function is a dict (changed from str) expected to contain args and their values. ex:

"function": {
"exponential": {
"variable0": "input_port1",
"scale": "scale",
"rate": "rate",
"bias": "bias",
"offset": "offset"
}
}

Why use this dictionary format instead of handling the function arguments in the 'args' field as with evaluable expressions? This change seems to add extra complexity

@harshithakolipaka
Copy link

hey @kmantel, I would like to work on this issue. Could you please assign this task to me .

@WhiteWolf47
Copy link

@kmantel I would like to work on this issue, would you please assign this issue to me.

@kmantel
Copy link
Contributor Author

kmantel commented Mar 7, 2023

Hi, will check back and assign one of you soon

@pgleeson
Copy link
Member

This issue is more to track a proposed design change to the MDF formal specification for parameters and functions rather than a bug fix I'm afraid. It requires examination of the merits of the change by the MDF developers rather than something that just needs a quick change in the code, so is probably something more for the actual internship rather than the contribution phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants