Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-examples #574

Closed
wants to merge 2 commits into from
Closed

Fix-examples #574

wants to merge 2 commits into from

Conversation

tdelmas
Copy link
Contributor

@tdelmas tdelmas commented Dec 8, 2023

What is the proposal?

Fix the examples to makes them valid JSON and conform to the GBFS specification.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

Only the examples.

@richfab richfab mentioned this pull request Dec 8, 2023
Merged
3 tasks
@richfab
Copy link
Contributor

richfab commented Dec 8, 2023

Great catches @tdelmas! Thank you for this contribution.

I noticed that we missed a few more typos on our side.

I created a new PR (#575) including your changes so that you don't need to spend more time on these typos.

Thank you!

@richfab richfab closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdelmas @richfab