Revert "audiopolicy: Fix call recording for legacy qcom HAL" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7e1c0f2 that commit broke almost all recording stuffs on some devices.
mokeeopensource
pushed a commit
that referenced
this pull request
Jan 4, 2020
Reporting video on upon first queue/dequeue buffer activity, off after a period of inactivity (3 sec currently). bug: 138381810 test: Manual testing for now; unit tests will come after. With BatteryStatService instrumented to print out noteVideo*: Test case #1: Camera recording (using GCA): Camera creates encoder immediately when Video tab is entered, but recording won't start until button is pressed. After recording is stopped, a new encoder is again created to prepare for next session. So under old scheme, video is on as soon as we're in Video tab, and off/on even pairs are seen when video is stopped. Video stats is basically always On when we're in video tab. With this CL one should see: - There shouldn't be videoOn when Video tab is first entered - Start recording and there should be a videoOn. - Stop recording and there should be a videoOff, AND videoOn shouldn't immediately follow. - Kill camera app during active recording, video should be restored to Off. Test case #2: Playback of video clips in Photos with pause With old scheme pausing state will be videoOn because codec instance is still there. With new scheme, videoOff should come after video is paused for 3 sec, and video On should come again when video is resumed. Change-Id: Ifa8aa5d8c2c95fa25393fcb936e6e54578716783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7e1c0f2
that commit broke almost all recording stuffs on some devices.