Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase project stability by fixing Manifest.toml #80

Closed
MilesCranmer opened this issue Oct 1, 2021 · 1 comment
Closed

Increase project stability by fixing Manifest.toml #80

MilesCranmer opened this issue Oct 1, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@MilesCranmer
Copy link
Owner

There are potential problems with only storing Project.toml and not the Manifest.toml file. Simply fixing Project.toml means the Julia dependencies could push patches, and with default PySR settings (update=True), there could be changes to the Julia dependencies which could break small things. For stability reasons, it doesn't seem smart to depend on so many user projects which could push a new patch and potentially break PySR. I think it might be better I manually update the PySR Manifest.toml, do a full run of testing on it, and only then allow any new patches through.

@MilesCranmer
Copy link
Owner Author

Irrelevant with #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant