Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let sympy use log2(x) instead of log(x)/log(2) #711

Open
MilesCranmer opened this issue Sep 4, 2024 Discussed in #710 · 2 comments · May be fixed by #712
Open

Let sympy use log2(x) instead of log(x)/log(2) #711

MilesCranmer opened this issue Sep 4, 2024 Discussed in #710 · 2 comments · May be fixed by #712
Labels
enhancement New feature or request

Comments

@MilesCranmer
Copy link
Owner

Discussed in #710

Originally posted by nerai September 3, 2024
The export to sympy currently translates log2(x) to log(x)/log(2). This is cumbersome if log2 is commonly used and makes the equations hard to read.

Sympy supports log2 natively, so I feel it would be appropriate to also translate log2 into that instead. It is perhaps possible to only fix the output in sympy, but ideally, it should be done in PySR directly.

@MilesCranmer MilesCranmer added the enhancement New feature or request label Sep 4, 2024
@MilesCranmer
Copy link
Owner Author

@nerai

@MilesCranmer
Copy link
Owner Author

I'm totally on board with this, just busy lately. If you want to make a PR I can merge it!

@nerai nerai linked a pull request Sep 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant