Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Spawn calls need timeouts #58

Open
MikeBishop opened this issue Jul 19, 2021 · 0 comments
Open

Async Spawn calls need timeouts #58

MikeBishop opened this issue Jul 19, 2021 · 0 comments

Comments

@MikeBishop
Copy link
Owner

The Tesla API's current most common way to break is by hanging forever, and the Python scripts currently let it. This is particularly pernicious for refresh, which can run during module startup and prevent other parts of initialization from ever running. This fix might take a couple possible forms:

  • Use Promise.race(...) to create a timeout on the async-spawn calls, so that we can abandon the Python invocations if they take too long.
  • Add timeouts to the HTTP calls within the Python scripts such that they are guaranteed to complete in a finite and reasonable amount of time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant