Clarify Custom Role Definition for AzureDevopsInfrastructure Principal #14134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs are a incomplete on permisisons needed in a custom role. It's also ambigious as to whether the `Reader` role is needed in addition to the custom role or not Solve this ambiguity by including the `Microsoft.Network/virtualNetworks/*/read` action in the custom role definition, and making clear that is an alternative to the two built in roles Added a missing permission required to delete a managed devops pool `Microsoft.Network/virtualNetworks/subnets/serviceAssociationLinks/delete` action required to delete a managed devops pool
|
@afscrome : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@steved0x Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
#afscrome Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs are incomplete on permissions needed in a custom role, as well as being ambigious as to whether the
Readerrole is needed in addition to the custom role or notSolve the ambiguity by including the
Microsoft.Network/virtualNetworks/*/readaction in the custom role definition, and making clear that is an alternative to the two built in rolesAdded a missing permission required to delete a managed devops pool
Microsoft.Network/virtualNetworks/subnets/serviceAssociationLinks/deleteaction required to delete a managed devops pool