Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectra from FPbase #92

Open
carandraug opened this issue Sep 5, 2019 · 2 comments
Open

spectra from FPbase #92

carandraug opened this issue Sep 5, 2019 · 2 comments

Comments

@carandraug
Copy link
Member

FPbase has a spectra and data for a bunch of proteins that we don't. We could have a script that downloads and converts it for spekcheck. Shouldn't be much work.

carandraug added a commit to carandraug/SpekCheck that referenced this issue Sep 5, 2019
…sue MicronOxford#92)

* src/update-from-fpbase.py: new script to convert a file with
  FPbase json spectra data to SPEKcheck format.
* Makefile: rule to download all proteins from FPbase and add them
  to SPEKcheck.
* NEWS: reference new script.
@carandraug
Copy link
Member Author

I now wrote a quick script that does that. Given a file with all the FPbase protein data on json format, converts to SPEKcheck format and saves to a specific file. I also added a makefile rule that downloads said file.

Only two issues:

#. mKOκ protein has issues not sure exactly where. The last character is a kappa and so name is κ but κ is displayed. Not sure exactly where the issue is, but may be on spekcheck.js assuming simpler filenames.

#. the new script is python 3.7 only

@carandraug
Copy link
Member Author

Spoke with Ian about including all the FPbase proteins on the next release. The problem with it is that it brings 244 fluorescent proteins which is a bit too much. Things we can do:

  • mention the script on the README and tell users to download and copy the ones they want
  • download them all, place them in a separate folder, and tell users to copy the ones they want
  • put them all anyway and tell users to remove the ones they don't want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant