Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit addition is heavy #75

Open
shaleh opened this issue Mar 28, 2022 · 4 comments
Open

Pre-commit addition is heavy #75

shaleh opened this issue Mar 28, 2022 · 4 comments

Comments

@shaleh
Copy link
Contributor

shaleh commented Mar 28, 2022

I tried to update to the new main this morning.
poetry run pre-commit install --install-hooks fails for me

[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('go', 'install', './...')
return code: 1
expected return code: 0
stdout:
    Executable `go` not found

Why do I need go? What is that giving the project that is helpful?

@MichaelAquilina
Copy link
Owner

🤔 didnt realise go was needed for one of them.

I guess that would be gitleaks: https://github.com/zricethezav/gitleaks

go isnt exactly a rare binary to find, but I do agree it seems a bit excessive to ask for it to be installed in a python project.

@shaleh
Copy link
Contributor Author

shaleh commented Mar 28, 2022

Can we ignore gitleaks? It does not feel relevant to the project. We are not likely to have password file right?

@MichaelAquilina
Copy link
Owner

I think its safe-ish to remove. The idea is to prevent tokens and secrets from mistakenly being committed. But I think that is more of a need on a larger team rather than a project maintained by an individual

@shaleh
Copy link
Contributor Author

shaleh commented Mar 28, 2022

See #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants