Options should use time values, but not pointer

[nejtr0n]

Time package documentation advises to use values, but not pointers.
https://github.com/golang/go/blob/master/src/time/time.go#L85-L87

keyfunc/options.go

Line 42 in 3dcaab5

RefreshInterval *time.Duration

[MicahParks]

Yup. Typically time.Duration should be stored as a value, not a pointer.

However, currently in this project they're all stored as pointers. This is because the presence of the time.Duration fields are optionally used to configure the program.

If you've come across an instance where the code follows a pointer reference where it's possible it could be nil, please draw attention to it.

[nejtr0n]

Imho we could test zero duration

type Test struct {
   duration time.Duration
}

data := &Test{}
fmt.Println(data.duration == 0)

[AlexanderYastrebov]

The obvious (but not mentioned) problem with pointer values is that it prevents use of struct literal to init options like:

jwks, err := keyfunc.Get(url, keyfunc.Options{
    RefreshInterval: 1 * time.Minute,
})

[MicahParks]

Please see the v0.10.0 release.

I plan on doing a v1.0.0 release sometime within the next few weeks. So anyone should feel free to raise issues about things that could be improved before the first major semver. If anyone is interested in the v1.0.0 discussion, feel free to participate here: #23