Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSU] Heartthrob Memorial: Under the Tree of Legends (Tokimeki Memorial Translation and MSU hack) - Konami voiceline missing & Intro is blacking out from time to time. #331

Open
Hobbesgoblin opened this issue May 17, 2022 · 13 comments

Comments

@Hobbesgoblin
Copy link

Expected behaviour (from snes9X emulator):
After the Konami jingle a voiceline saying "Konami"
Intro is playing normally.

Seen behavious on MiSTer:
Voiceline is missing
Intro blacks out for a moment a twice in the beginning. (consistent at the same places before the title card)

@sorgelig
Copy link
Member

"Konami" voice is missing, yes, but i don't see any issues in intro video

@Relikk
Copy link

Relikk commented May 17, 2022

I can confirm dropouts in the video on my set-up, also. From SD card. We were comparing with Kitrinx on the Discord with Road Avenger. Their intro video was perfect and they mentioned they were loading from their Network, but a few of us loading from SD card were getting an error.

@sorgelig
Copy link
Member

data track is preloaded fully at rom loading. So it doesn't matter network or SD card.
Can someone make a video clip showing the problem?

@Hobbesgoblin
Copy link
Author

Am also loading from SD card.
I dont have any capture equipment therefore phonecam. Poor quality, i know, but dropouts are visible

MOV_0490_smol.mp4

.

@birdybro
Copy link
Member

Does this occur when you switch vsync_adjust to 0 in the MiSTer.ini?

@Hobbesgoblin
Copy link
Author

Hobbesgoblin commented May 17, 2022

Video was taken hat vsync_adjust=0
Just tested all 3 modes.
Dropouts occur at vsync_adjust =0 and vsync_adjust = 1
Drpouts do NOT occur at vsync_adjust = 2

@birdybro
Copy link
Member

The ROM is likely producing video that is out of spec for the SNES. The MiSTer isn't a software emulator so you can't get away with hacks like that. At least this is my assumption of what is happening given that vsync_adjust=2 works, and the others don't.

@sorgelig
Copy link
Member

this should fix video problem:
SNES.ZIP

it doesn't fix absence of "konami" voice.

@Hobbesgoblin
Copy link
Author

this should fix video problem: SNES.ZIP

it doesn't fix absence of "konami" voice.

Yes this fixes the dropout issues in the video on vsync_adjust = 0 and 1

@hackgrid
Copy link

hackgrid commented Nov 9, 2022

I just wanted to add, that while bsnes plays this "Konami"-sound fine, sd2snes/fxpak on a real hardware snes also misses this voiceline!

So maybe Mister is "correct" there? Or there is the same bug in sd2snes and Mister cores.

@Relikk
Copy link

Relikk commented Nov 9, 2022

No, it's a patch issue. MSU1 implementation in MiSTer is still buggy, but this issue is not normal or intended behaviour. If the jingle plays on an emulator and not on an SD2SNES or MiSTer, or whatever, then there is a coding error or a missing command in the patch source.

Just checked the hex. The loop is missing, and the code is complex.

If I read the code correctly it is:
STX $2004
LDA #$01
STA $2007

It needs to be something like this to be correct:
STX $2004
loop:
BIT $2000
BVS loop

LDA #$01
STA $2007

@Relikk
Copy link

Relikk commented Nov 10, 2022

So, yes. There is no wait loop on further inspection with a debugger.

7cee17 ldx #$0001 A:00ff X:0001 Y:96dd S:1fc0 D:0000 DB:81 N.M..I.C V:236 H:196 F:28
7cee1a stx $2004 [812004] A:00ff X:0001 Y:96dd S:1fc0 D:0000 DB:81 ..M..I.C V:236 H:202 F:28
7cee1d plx A:00ff X:0001 Y:96dd S:1fc0 D:0000 DB:81 ..M..I.C V:236 H:211 F:28
7cee1e lda #$01 A:00ff X:0001 Y:96dd S:1fc2 D:0000 DB:81 ..M..I.C V:236 H:220 F:28
7cee20 sta $2007 [812007] A:0001 X:0001 Y:96dd S:1fc2 D:0000 DB:81 ..M..I.C V:236 H:224 F:28

But any time a byte is written in an attempt to fix it, the checksum is bad and it doesn't boot anymore. CRC Fix should make it work, but it doesn't boot.

EDIT: The checksum can be fixed but it still doesn't boot. Speculation that there was a tamper check in the code somewhere, but nothing has been found.

Best to report it to the authors and let them sort it out.

@hackgrid
Copy link

Thanks for checking and trying to create a fix! :)
Unfortunately I dont know how to contact them, they seem pretty closed off?
Hopefully somebody knows how to contact :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants