Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_manifest_dependencies: dependency added when already present #25

Open
Achllle opened this issue Jul 17, 2024 · 0 comments
Open

check_manifest_dependencies: dependency added when already present #25

Achllle opened this issue Jul 17, 2024 · 0 comments

Comments

@Achllle
Copy link
Contributor

Achllle commented Jul 17, 2024

I'm not sure if this is different from #24, adding separate issue for it in case it is

Starting with the following package.xml:

<?xml version="1.0"?>
<package format="2">
  <name>mypkg</name>
  <version>0.0.0</version>
  <description>description</description>
  <maintainer email="[email protected]">person</maintainer>

  <license>TODO</license>

  <depend>rospy</depend>
  <depend>std_msgs</depend>

  <buildtool_depend>catkin</buildtool_depend>

  <build_depend>message_generation</build_depend>
  <build_export_depend>message_runtime</build_export_depend>
  <exec_depend>message_runtime</exec_depend>

</package>

Running glint_ros -f mypkg check_manifest_dependencies suggests:

+   <depend>rospy</depend>
    <depend>rospy</depend>

which of course prevents building:

- The generic dependency on 'rospy' is redundant with: build_depend, build_export_depend, exec_depend

EDIT: I should note that this happened after rerunning the tool after fixing the spurious build_export_depend flag from #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant