Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Nametags module #4869

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

RealMuffinTime
Copy link
Contributor

Type of change

  • Bug fix
  • New feature

Changes to Nametags module

  • add TNT minecarts (TNT entities were present, but TNT minecarts not)
  • ignore empty ItemStacks (sometimes it was possible to see Air 0x items if these were dropped and picked up fast)
  • more default values (Module didn't had any hints on providing features for these entities)
  • better description (Module didn't had any hints on providing features for other entities than players)

How Has This Been Tested?

2024-08-28_19 37 04

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@RacoonDog
Copy link
Contributor

Overall LGTM, though I dont think the defaults for the entity whitelist setting should be changed

@RealMuffinTime
Copy link
Contributor Author

Should I then put the possible custom nametags in the description?

@Wide-Cat Wide-Cat merged commit c67f2b9 into MeteorDevelopment:master Aug 29, 2024
1 check passed
@RealMuffinTime RealMuffinTime deleted the nametags branch August 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants