Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an error in arguments that made it impossible to use non-English characters, words with spaces and symbols. #4794

Closed
wants to merge 2 commits into from

Conversation

ItzLauron
Copy link

@ItzLauron ItzLauron commented Jul 31, 2024

Type of change

  • Bug fix

Description

Fixed an error in arguments that made it impossible to use non-English characters, words with spaces and symbols.(#4492)

How Has This Been Tested?

It was tested with the command .friends add абоба

Checklist:

  • My code follows the style guidelines of this project.
  • I have tested the code in both development and production environments.

@ItzLauron ItzLauron changed the title Ffixed a bug for arguments that allows the use of non-English characters, words with spaces and symbols. Fixed a bug for arguments that allows the use of non-English characters, words with spaces and symbols. Jul 31, 2024
@ItzLauron ItzLauron changed the title Fixed a bug for arguments that allows the use of non-English characters, words with spaces and symbols. Fixed an error in arguments that made it impossible to use non-English characters, words with spaces and symbols. Jul 31, 2024
@RacoonDog
Copy link
Contributor

please keep the same semantics as StringReader#readString

@ItzLauron
Copy link
Author

ItzLauron commented Jul 31, 2024

please keep the same semantics as StringReader#readString

it does not support spaces, symbols + StringArgumentType from the default brigadier parses the argument the same way as in my change

@RacoonDog
Copy link
Contributor

RacoonDog commented Aug 1, 2024

please keep the same semantics as StringReader#readString

StringArgumentType from the default brigadier parses the argument the same way as in my change

StringReader#readString reads either a single unquoted word or a whole quoted string, yours consumes the rest of the string, breaking every command that requires subsequent arguments

@Julieisbaka
Copy link

omg lol we need this

@Wide-Cat Wide-Cat closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants