Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre Renders Bow #4765 #4772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnandBhasme
Copy link
Contributor

Type of change

  • Bug fix
  • New feature

Description

Adds option to Pre renders the projectile of arrow from bow.

Related issues

#4765

How Has This Been Tested?

2024-07-25_00 12 04
2024-07-25_00 16 29

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@AnandBhasme AnandBhasme marked this pull request as draft July 24, 2024 18:52
@AnandBhasme
Copy link
Contributor Author

AnandBhasme commented Jul 24, 2024

I was wondering whether #4773 can be fixed too while I am working on this module. I tested and I am able to fetch the nbt tag of flight duration of rocket present in the crossbow.
But as per https://minecraft.fandom.com/wiki/Crossbow
Screenshot 2024-07-25 003653
the distance travelled by the rocket is random in a range.
I reckon we can make render it such that the render line till minimum (of range) will be same as now (a solid line) and the distance of range will have a dotted line and at end something that represents a explosion.

Is it worth working over? I wanted opinions...

@AnandBhasme AnandBhasme marked this pull request as ready for review July 24, 2024 19:11
@RacoonDog
Copy link
Contributor

I dont believe meteor client has the capabilities to render dotted lines, though we could render a full line up until the minimum, and then fade out the opacity as it reaches the maximum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants