Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: feat: Add experimental settings toggle for transactions redesign (#26… #27166

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 16, 2024

…010)

Cherry-pick PR #26010 into Version-v12.3.0

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 16, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 16, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner September 16, 2024 13:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d77b3c6]
Page Load Metrics (1808 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22424951599576276
domContentLoaded16302428177818287
load16492512180819594
domInteractive167236157

@seaona
Copy link
Contributor

seaona commented Sep 23, 2024

hi there 👋 can we merge this? @pedronfigueiredo

@pedronfigueiredo
Copy link
Contributor Author

@seaona @danjm wanted to investigate something related to this PR before merging it and I don't know if that investigation has been concluded yet.

@danjm danjm merged commit 4c4b5c7 into Version-v12.3.0 Sep 23, 2024
75 of 77 checks passed
@danjm danjm deleted the pnf/cherry-pick-transaction-toggle branch September 23, 2024 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Sep 23, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.3.0 on PR, as PR was cherry-picked in branch 12.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants