Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter only EVM address when calling syncWithAddresses #25313

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

montelaidev
Copy link
Contributor

Description

This PR applies a removes all non EVM addresses prior to calling syncWithAddresses during _onKeyringControllerUpdate. This is because the AccountTracker does not support non EVM addresses. The AccountTracker now also subscribes to onSelectedEvmAccountChange instead of onSelectedAccountChange

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev requested a review from a team as a code owner June 14, 2024 09:50
@montelaidev montelaidev self-assigned this Jun 14, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.67%. Comparing base (8539477) to head (a78087a).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25313      +/-   ##
===========================================
- Coverage    65.68%   65.67%   -0.01%     
===========================================
  Files         1377     1377              
  Lines        54593    54593              
  Branches     14304    14303       -1     
===========================================
- Hits         35854    35850       -4     
- Misses       18739    18743       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2bb3a2a]
Page Load Metrics (50 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6310883126
domContentLoaded9141121
load397450105
domInteractive9141121
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 153 Bytes (0.00%)
  • ui: -902 Bytes (-0.01%)
  • common: 902 Bytes (0.01%)

@ccharly ccharly changed the title fix: filter only evm address when calling syncWithAddresses fix: filter only EVM address when calling syncWithAddresses Jun 14, 2024
app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved
app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved
app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved
app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved
app/scripts/metamask-controller.test.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [a78087a]
Page Load Metrics (222 ± 242 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint76210983115
domContentLoaded9261232
load421750222503242
domInteractive9261232
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 153 Bytes (0.00%)
  • ui: -902 Bytes (-0.01%)
  • common: 902 Bytes (0.01%)

@montelaidev montelaidev merged commit 901289c into develop Jun 14, 2024
74 checks passed
@montelaidev montelaidev deleted the fix/filter-non-evm-address-to-syncWithAddresses branch June 14, 2024 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants