Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v11 RC issues following merge #20690

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Fix v11 RC issues following merge #20690

merged 3 commits into from
Sep 1, 2023

Conversation

FrederikBolding
Copy link
Member

Explanation

Fixes a few issues with the v11 RC following a master merge.

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 1, 2023
@FrederikBolding FrederikBolding changed the title v11 fixes following merge Fix v11 RC issues following merge Sep 1, 2023
@FrederikBolding FrederikBolding marked this pull request as ready for review September 1, 2023 13:34
@FrederikBolding FrederikBolding requested review from a team as code owners September 1, 2023 13:34
Gudahtt
Gudahtt approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding merged commit 10ccbfc into Version-v11.0.0 Sep 1, 2023
54 of 56 checks passed
@FrederikBolding FrederikBolding deleted the fb/v11-fixes-following-merge branch September 1, 2023 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [1b2067c]
Page Load Metrics (1545 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint109155122136
domContentLoaded1406172115459043
load1406172215459043
domInteractive1406172115459043

@gauthierpetetin gauthierpetetin added the release-11.0.0 Issue or pull request that will be included in release 11.0.0 label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
release-11.0.0 Issue or pull request that will be included in release 11.0.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrederikBolding @metamaskbot @Gudahtt @gauthierpetetin