-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Increase network name threshold before showing tooltip #20009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [0c5e27a]
Page Load Metrics (1565 ± 39 ms)
Bundle size diffs
|
Builds ready [9095e16]
Page Load Metrics (1508 ± 33 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20009 +/- ##
========================================
Coverage 69.47% 69.47%
========================================
Files 989 989
Lines 37378 37378
Branches 10023 10023
========================================
Hits 25965 25965
Misses 11413 11413
|
NidhiKJha
approved these changes
Jul 18, 2023
vthomas13
approved these changes
Jul 18, 2023
metamaskbot
added
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Jul 18, 2023
kevinghim
added
team-extension-client
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
labels
Jul 25, 2023
Gudahtt
added
release-11.1.0
Issue or pull request that will be included in release 11.1.0
and removed
release-10.36.0
Issue or pull request that will be included in release 10.36.0
labels
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.1.0
Issue or pull request that will be included in release 11.1.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
@rachelcope had suggested we increase the threshold for network name before showing the tooltip upon hover. I agree, since the whole Avalanche chain name fits. A small increase makes sense.
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.