Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Increase network name threshold before showing tooltip #20009

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jul 13, 2023

Explanation

@rachelcope had suggested we increase the threshold for network name before showing the tooltip upon hover. I agree, since the whole Avalanche chain name fits. A small increase makes sense.

Manual Testing Steps

  1. Add Avalanche chain -- open network -- hover over network name -- see no tooltip
  2. Add super long network name -- open network -- hover over network name -- see tooltip upon hover

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 13, 2023 19:26
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [0c5e27a]
Page Load Metrics (1565 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1061961312110
domContentLoaded1385167915648139
load1385167915658139
domInteractive1385167915648139
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [9095e16]
Page Load Metrics (1508 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1102521403617
domContentLoaded1404167515086833
load1404167515086833
domInteractive1404167515086833
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #20009 (9095e16) into develop (ea589a6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #20009   +/-   ##
========================================
  Coverage    69.47%   69.47%           
========================================
  Files          989      989           
  Lines        37378    37378           
  Branches     10023    10023           
========================================
  Hits         25965    25965           
  Misses       11413    11413           
Impacted Files Coverage Δ
.../multichain/network-list-item/network-list-item.js 97.06% <100.00%> (ø)

@darkwing darkwing merged commit 8f8613a into develop Jul 18, 2023
9 checks passed
@darkwing darkwing deleted the longer-network-tooltip branch July 18, 2023 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 18, 2023
@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 25, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants