[Bug]: After Metamask 12.3.0 update, recently updated tokens in Contract-metadata are not detected in Metamask #27614
Labels
external-contributor
regression-prod-12.3.0
Regression bug that was found in production in release 12.3.0
Sev1-high
High severity; partial loss of service with severe impact upon users, with no workaround.
team-assets
type-bug
Comments
mandoopapa
changed the title
metamaskbot
added
external-contributor
regression-prod-12.3.0
benjisclowder
added
team-assets
Sev1-high
4 tasks
sahar-fehri
added a commit
to MetaMask/core
that referenced
this issue
Oct 9, 2024
## Explanation What motivates this change is this user report MetaMask/metamask-extension#27614 Based on discussions we had with teams; seems like initially, we added the `includeDuplicateSymbolAssets` because there were concerns around duplicate symbols being scammy and the increased size of tokenList. For the duplicate symbols being scammy concern; i think our usage of `occurrencesFloor=3` is helping us filter out any scam tokens. Having tokens with the same symbol is not unusual and it does not necessarily mean that the token is a scam. For the tokenList size; we thought that; today; the tokenList we get without `includeDuplicateSymbolAssets` has around 4500 tokens. With the `includeDuplicateSymbolAssets` it has around 4000. Which does not seem like it should have a huge impact. We thought that token the tokenList size would increase regardless in future, and if users add their tokens to lists and expect to see them we should not be filtering them out even if they have duplicates. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/assets-controllers` - **Removed**: Removed param `includeDuplicateSymbolAssets` in our api call to token-api. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
7 tasks
|
Hi @mandoopapa 👋 ; |
|
Great, hopefully we'll be done with the wrapped token soon, so we can see both tokens in the metamask :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Hi team.
Recently there was an update to Metamask 12.3.0, and after the update we noticed that our project team's token, which was merged from the Contract-metadata repository on July 16, is not being detected in Metamask.
I have attached some relevant information below.
Please check them out.
Thank you.
MetaMask/contract-metadata#1329
Token Information
Tokamak Network Token
Network : Ethereum
Token Address : 0x2be5e8c109e2197D077D13A82dAead6a9b3433C5
Symbol : TON
Etherscan(verified) : https://etherscan.io/token/0x2be5e8c109e2197D077D13A82dAead6a9b3433C5
Expected behavior
No response
Screenshots/Recordings
No response
Steps to reproduce
After selecting Ethereum Mainnet as the network, Go to 'import token'
tokamak or ton, the above mentioned tokens are not found.
Before the 12.3.0 update, they were found.
Error messages or log output
No response
Detection stage
In production (default)
Version
12.3.0
Build type
None
Browser
Chrome
Operating system
Windows
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: