Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent transaction failures for ledger users when requests to the ledger cdn fail #25666

Open
danjm opened this issue Jul 3, 2024 · 2 comments
Assignees
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-hardware-wallets type-bug

Comments

@danjm
Copy link
Contributor

danjm commented Jul 3, 2024

As was the case here #25623 and here #17964, it is possible for server side problems related to the https://cdn.live.ledger.com/plugins/ethereum.json endpoint to cause ledger transactions to fail (before they are published to the blockchain).

If the network request in loadInfosForContractMethod (https://github.com/LedgerHQ/ledger-live/blob/173bb3c84cc855f83ab8dc49362bc381afecc31e/libs/ledgerjs/packages/hw-app-eth/src/services/ledger/contracts.ts#L17) call in the signTransaction method of the Eth class in the hw-app-eth library fails, then transaction signing will fail.

Ledger users should be able to sign transactions even if ledger servers are down entirely.

The network requests made here get information that can be useful for ledger users, and help them make secure decisions. As we resolve this issue, we should be mindful that in the case where ledger servers are down (or there are CORS issues as was the case in the above linked issues), the users are effectively "blind signing" on the device, without helpful cues like token names or symbols. We may want to give a warning in these cases.

@danjm danjm added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-hardware-wallets labels Jul 3, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jul 3, 2024
@lambertkevin
Copy link

This problem has been fixed in a later version of hw-app-eth, Metamask is still using a 3 year old version of it, but we can't update the lib in your stack because of this issue: MetaMask/eth-ledger-bridge-keyring#217 😞

Copy link
Contributor

github-actions bot commented Oct 2, 2024

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-hardware-wallets type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants