Prevent transaction failures for ledger users when requests to the ledger cdn fail #25666
Labels
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
Sev2-normal
Normal severity; minor loss of service or inconvenience.
stale
issues and PRs marked as stale
team-hardware-wallets
type-bug
As was the case here #25623 and here #17964, it is possible for server side problems related to the https://cdn.live.ledger.com/plugins/ethereum.json endpoint to cause ledger transactions to fail (before they are published to the blockchain).
If the network request in
loadInfosForContractMethod
(https://github.com/LedgerHQ/ledger-live/blob/173bb3c84cc855f83ab8dc49362bc381afecc31e/libs/ledgerjs/packages/hw-app-eth/src/services/ledger/contracts.ts#L17) call in thesignTransaction
method of the Eth class in thehw-app-eth
library fails, then transaction signing will fail.Ledger users should be able to sign transactions even if ledger servers are down entirely.
The network requests made here get information that can be useful for ledger users, and help them make secure decisions. As we resolve this issue, we should be mindful that in the case where ledger servers are down (or there are CORS issues as was the case in the above linked issues), the users are effectively "blind signing" on the device, without helpful cues like token names or symbols. We may want to give a warning in these cases.
The text was updated successfully, but these errors were encountered: