Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: all accounts on polygon network are unusable with msg: A previous transaction is still being signed or submitted #23361

Closed
rouzwelt opened this issue Mar 7, 2024 · 26 comments · Fixed by #24027, MetaMask/core#4658 or #26963
Assignees
Labels
external-contributor regression-prod-11.11.4 Regression bug that was found in production in release 11.11.4 release-11.16.0 Issue or pull request that will be included in release 11.16.0 release-12.3.0 Issue or pull request that will be included in release 12.3.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team type-bug

Comments

@rouzwelt
Copy link

rouzwelt commented Mar 7, 2024

Describe the bug

So in past 2 days or so, all my accounts in metamask chrome extension are unusable when trying to send a token with this msg appearing on the screen A previous transaction is still being signed or submitted.
this happens only on Polygon network and for all accounts, not just one.
I should mention other networks are fine and work as normal, and also on polygon network I was able to do a swap using metamask swap, but the issue still present even after that swap when trying to send a token.
I should also mention I already tried clearing data/reset nonce, but still no luck. also tried different providers urls, and still no luck.
Also another thing to mention is that I was able to perform a approval tx from quickswap website, but when it came to do the actual swap tx, still encountered the same error msg on metamask panel, but approval tx went through ok.

Expected behavior

No response

Screenshots/Recordings

Screenshot 2024-03-07 at 1 22 03 AM

Steps to reproduce

  1. Go to polygon network
  2. try to send any token

Error messages or log output

No response

Version

11.11.4

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

this is critical because it has blocked me from sending any tokens on polygon network

@metamaskbot metamaskbot added external-contributor regression-prod-11.11.0 Regression bug that was found in production in release 11.11.0 regression-prod-11.11.3 Regression bug that was found in production in release 11.11.3 and removed regression-prod-11.11.0 Regression bug that was found in production in release 11.11.0 labels Mar 7, 2024
@davigp
Copy link

davigp commented Mar 8, 2024

same issue,I'm able to transfer tokens, however when I try to interact with a contract this error happens, even for new account without any previous contract interaction.

@rouzwelt
Copy link
Author

rouzwelt commented Mar 8, 2024

same issue,I'm able to transfer tokens, however when I try to interact with a contract this error happens, even for new account without any previous contract interaction.

looks like this is a known bug from past few versions, and it has been flagged as being fixed, so hopefully we get a fix soon for this

@rouzwelt
Copy link
Author

rouzwelt commented Mar 8, 2024

error still present in v11.11.4

@metamaskbot metamaskbot added regression-prod-11.11.4 Regression bug that was found in production in release 11.11.4 and removed regression-prod-11.11.3 Regression bug that was found in production in release 11.11.3 labels Mar 8, 2024
@royalblayd
Copy link

royalblayd commented Mar 10, 2024

Have you tried reaching out to the MetaMask team ?

@John2204
Copy link

I can also confirm error still presents for me also after the recent update.

@bear7bull
Copy link

Hi, I have the same issue but on BSC network...

@froid1911
Copy link

same here with polygon

@hiteshdamke
Copy link

i also face this problem

@Mcshowromzz
Copy link

I have same problem , if anyone found solution

@gauthierpetetin gauthierpetetin added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-system DEPRECATED: please use "team-confirmations" label instead team-confirmations-planning (only for internal use within Confirmations team) labels Mar 14, 2024
@MetaMask MetaMask deleted a comment from royalblayd Mar 14, 2024
@cxheng315
Copy link

"clear activity tab" , works for me
https://twitter.com/calibreftw/status/1766446629081788491

@rouzwelt
Copy link
Author

rouzwelt commented Mar 17, 2024

"clear activity tab" , works for me
https://twitter.com/calibreftw/status/1766446629081788491

yup this seemed resolve the issue for me too, the catch is you need to clear data for all your accounts and not just one of them

@bschorchit bschorchit removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-planning (only for internal use within Confirmations team) labels Mar 18, 2024
@Corfucinas
Copy link

"clear activity tab" , works for me
https://twitter.com/calibreftw/status/1766446629081788491

yup this seemed resolve the issue for me too, the catch is you need to clear data for all your accounts and not just one of them

Very bad suggestion for when you have hundreds of wallets....

@OGPoyraz OGPoyraz self-assigned this Mar 22, 2024
@OGPoyraz
Copy link
Member

Hello @rouzwelt ,
Unfortunately I cannot reproduce the issue on my end. I made send, swap, contract interaction on several and same accounts but no luck.
Could you please clarify what exactly have you done to see that error?

@rouzwelt
Copy link
Author

Hello @rouzwelt ,
Unfortunately I cannot reproduce the issue on my end. I made send, swap, contract interaction on several and same accounts but no luck.
Could you please clarify what exactly have you done to see that error?

well I dont really know how to reproduce this, it happened to me out of nowhere, one day i opened my metamaak to send some tokens and saw that error only on polygon network, and it stayed there after few mm releases, until i saw a comment from somone on this post suggesting a possible workaround and that fixed the issue for me.

but as you can see it is not only me, others have/are experiencing the same issue.

if you ask me it looks like to be some sort of cache/storage issue, because that workaround is clearing the cache basically and it is fixing the issue, at least it did for me and a couple other guys.

@OGPoyraz
Copy link
Member

Thank you for sharing your experience and the workaround that helped resolve the issue for you @rouzwelt

Since we don't know the steps to reproduce this issue, there is also another way that you can help us.
You can send here the "state logs" which could be find under "Settings > Advanced > State Logs". This will help us to understand which exact transaction make it stuck.

It's totally clear that one of the transactions that happened earlier stuck the upcoming transactions. But there are limited ways for us to understand what exactly causing the issue.

Also, in original issue, you didn't opt in but I need to ask again to be sure, were you using hardware wallet before doing the stucked transaction?

Thank you again for your cooperation and patience.

@benjisclowder
Copy link
Contributor

benjisclowder commented Jun 14, 2024

Collaborative Effort Required for Root Cause Analysis (RCA) on Critical Issues

We are quickly approaching the end of the quarter and we encourage you once again to take some moments and perform RCA on this critical issue. You may do so by answering the questions below:

  1. What PR fixed the issue?
  2. Can you pinpoint the commit from which the issue originated?
  3. Write a short explanation of the technical cause of the bug
  4. How could we have avoided merging this bug? What would have had to be different about our code, tests or processes?
    4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue?
    4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue?
    4.3. If your answer to a and b is no, then is there anything at all that you can think of that, if it had been different before this bug was introduced, would have prevented it from being merged?

Please provide your answers as a reply to this comment and tag me as well.

You can read more about the initiative here. Thank you!

Tagging eng. who added the fix: @OGPoyraz
cc: @cryptotavares

@OGPoyraz
Copy link
Member

Collaborative Effort Required for Root Cause Analysis (RCA) on Critical Issues

We are quickly approaching the end of the quarter and we encourage you once again to take some moments and perform RCA on this critical issue. You may do so by answering the questions below:

  1. What PR fixed the issue?
  2. Can you pinpoint the commit from which the issue originated?
  3. Write a short explanation of the technical cause of the bug
  4. How could we have avoided merging this bug? What would have had to be different about our code, tests or processes?
    4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue?
    4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue?
    4.3. If your answer to a and b is no, then is there anything at all that you can think of that, if it had been different before this bug was introduced, would have prevented it from being merged?

Please provide your answers as a reply to this comment and tag me as well.

You can read more about the initiative here. Thank you!

Tagging eng. who added the fix: @OGPoyraz cc: @cryptotavares

What PR fixed the issue?

Can you pinpoint the commit from which the issue originated?

Write a short explanation of the technical cause of the bug

  • MM persists TransactionController states which hold all past transactions that user did. Some of those old transactions have status of signed or approved status which is not an issue. But after recent implementation it was a blocking the user with stating that there is actually an ongoing transaction. Because the changes assumed there could be no final signed or approved status tied to a transaction.
    We simply added a migration for the users had these type of transactions in their MM state and finalise those ones manually.

How could we have avoided merging this bug? What would have had to be different about our code, tests or processes?
4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue?

  • Since this is really hard to foresee such an edge case maybe more manual test with such history / background with an account would make us identify the bug.

4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue?

  • The migration could have been pushed with the changes so users wouldn't face such issue. But as mentioned above this would definitely need to be identify upfront, otherwise it wouldn't be possible.

@benjisclowder fyi

@adapt7
Copy link

adapt7 commented Aug 27, 2024

Hi team. When are you going to fix the issue? It's happening to many users. Workaround to "clear activity tab data" won't work if ones have thousands of wallets. Please can you provide a fix, MetaMask is not usable with this error.

To add: I have no waiting / mempool / unfinished transactions on any wallet while the error is there and blocking me from making ANY transaction from any wallet.

@benjisclowder @OGPoyraz

@adapt7
Copy link

adapt7 commented Aug 28, 2024

@benjisclowder @OGPoyraz or any admin can you please delete the above post from royalblayd, it is clearily a scam attempt.

@royalblayd
Copy link

@adapt7 I've done you the favors. Enjoy your day.

@adapt7
Copy link

adapt7 commented Aug 31, 2024

Guys, is there any fix for this. It's so frustrating.

Clearing activity tab data for all wallets is not a solution when having 1k+ wallets. Please can you fix or provide any workaround?

@Gudahtt
Copy link
Member

Gudahtt commented Sep 2, 2024

Reopening for investigation again

@bschorchit
Copy link

We're targeting v12.3 for a fix

@matthewwalsh0 matthewwalsh0 added release-blocker This bug is blocking the next release release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Sep 12, 2024
@bschorchit bschorchit added regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 and removed team-confirmations-system DEPRECATED: please use "team-confirmations" label instead regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 labels Sep 12, 2024
@matthewwalsh0 matthewwalsh0 reopened this Sep 17, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 17, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 29, 2024
@bfondevila
Copy link

I can confirm on Version 12.2.X this was still an issue - on version 12.4.0 of the Metamask extension now, my accounts are working again as expected, without having to clear activity tab or anything similar.

@adapt7
Copy link

adapt7 commented Oct 10, 2024

I can also confirm, the latest version fixed the issue. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-prod-11.11.4 Regression bug that was found in production in release 11.11.4 release-11.16.0 Issue or pull request that will be included in release 11.16.0 release-12.3.0 Issue or pull request that will be included in release 12.3.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team type-bug
Projects
Archived in project