Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

5.1.0 #151

Merged
merged 3 commits into from
Sep 13, 2023
Merged

5.1.0 #151

merged 3 commits into from
Sep 13, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 2, 2023

This is the release candidate for version 5.1.0.

Also fixes an incorrect entry for v5.0.0:

"node": ">=14.0.0"


Blocked by:

@socket-security
Copy link

socket-security bot commented Sep 2, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/ethereumjs-tx 1.0.1 None +1 17.8 kB types
@types/randombytes 2.0.0 None +0 2.8 kB types
ethereumjs-tx 1.3.7 filesystem +36 6.38 MB holgerd77
@metamask/eslint-config-typescript 11.1.0 None +0 16.9 kB metamaskbot
@metamask/utils 5.0.2 None +3 438 kB metamaskbot

🚮 Removed packages: @metamask/[email protected]

@socket-security
Copy link

socket-security bot commented Sep 2, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @types/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @types/[email protected], [email protected], @types/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor

@SocketSecurity ignore-all

@legobeat legobeat marked this pull request as ready for review September 12, 2023 09:43
@legobeat legobeat requested a review from a team as a code owner September 12, 2023 09:43
@legobeat legobeat requested review from a team September 13, 2023 06:31
@Mrtenz
Copy link
Member

Mrtenz commented Sep 13, 2023

Looks like typedoc is missing? 🤔

@legobeat
Copy link
Contributor

legobeat commented Sep 13, 2023

Looks like typedoc is missing? 🤔

Aah, you are right, that explains the failing "publish rc docs" jobs I guess.

Looks like this was never actually working: 4abfbe9#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Worth holding this one to wait for that to be sorted out?

EDIT: Moving forward with publish: Docs seem to never really have been advertised, available, or missed for this package. Addressing should be done but can be sorted out separately from this release.

@legobeat legobeat merged commit d0d5c97 into main Sep 13, 2023
20 of 21 checks passed
@legobeat legobeat deleted the release/5.1.0 branch September 13, 2023 22:28
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
* 5.1.0
* fix incorrect changelog entry for 5.0.0

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
* 5.1.0
* fix incorrect changelog entry for 5.0.0

---------
This was originally merged as d0d5c97
but rebased on top of MetaMask#157 to retrigger the publish.
---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
* 5.1.0
* fix incorrect changelog entry for 5.0.0

---------
This was originally merged as d0d5c97
but rebased on top of MetaMask#157 to retrigger the publish.
---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
* 5.1.0
* fix incorrect changelog entry for 5.0.0

---------
This was originally merged as d0d5c97
but rebased on top of MetaMask#157 to retrigger the publish.
---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
This reverts commit d0d5c97 which released
v5.1.0. This is only done in order to get a proper publish from the
main branch after merge of MetaMask#157, which fixes a CI error.

5.1.0 will be rereleased and published as-is.
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Sep 14, 2023
This reverts commit d0d5c97 which released
v5.1.0. This is only done in order to get a proper publish from the
main branch after merge of MetaMask#157, which fixes a CI error.

5.1.0 will be rereleased and published as-is.
legobeat added a commit that referenced this pull request Sep 15, 2023
This reverts commit d0d5c97 which released
v5.1.0. This is only done in order to get a proper publish from the
main branch after merge of #157, which fixes a CI error.

5.1.0 will be rereleased and published as-is.
@legobeat legobeat mentioned this pull request Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants