Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate CSS Color Variable Generation from Figma JSON #720

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brianacnguyen
Copy link
Contributor

Description

  • This PR seeks to add automation scripts to convert json files to css files for brand colors and themed colors

Related issues

Fixes: #662

Manual testing steps

  1. run node scripts/brandColors.jsonToCss.js or node scripts/themedColors.jsonToCss.js

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system label Jun 3, 2024
@brianacnguyen brianacnguyen self-assigned this Jun 3, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner June 3, 2024 17:08
@metamaskbot
Copy link
Collaborator

Builds ready [5bc04dc]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [f9bcd98]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [6881475]

Storybook: Storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate CSS Color Variable Generation from Figma JSON with Style Dictionary
2 participants