Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build check to pull requests #59

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Add build check to pull requests #59

merged 4 commits into from
Sep 22, 2023

Conversation

jennyhickson
Copy link
Collaborator

@jennyhickson jennyhickson commented Sep 21, 2023

Attempting to modify the current build and deploy workflow to run with a pull request as well, but to not do the deploy part unless pushing to main. Will close and open this PR multiple times as part of testing!

Closes #60

@jennyhickson jennyhickson linked an issue Sep 21, 2023 that may be closed by this pull request
@jennyhickson jennyhickson reopened this Sep 21, 2023
@jennyhickson jennyhickson changed the title add build only workflow Add build check to pull requests Sep 21, 2023
@jennyhickson jennyhickson reopened this Sep 21, 2023
@jennyhickson
Copy link
Collaborator Author

Check successfully passed and skipped the deploy state. Only committing to MAIN will prove that the deploy state still works...

Copy link
Contributor

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made all look logical and like they'd do what you expect. I'll leave off committing this until tomorrow so you're around if it all falls over.

@james-bruten-mo james-bruten-mo merged commit 17f67ae into main Sep 22, 2023
3 checks passed
@james-bruten-mo james-bruten-mo deleted the new_workflow branch September 22, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup a workflow to test building the docs as part of the PR
2 participants