Update path to update_all.py cos I deleted it.... #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-sharp
requested review from
a team and
ericaneininger
and removed request for
a team
t00sa
reviewed
Jul 30, 2024
There was a problem hiding this comment.
I'm going to pick this up for Erica, mostly because it's just tripped me up in a Jules/UM linked ticket.
I've suggested using ./admin/... style paths for upgrade_all.py because that's what the Jules section uses and it would be nice to keep the two consistent. I also like it because it makes it easier to copy and paste.
It occurs to me that we might want to update the wording of the previous section to say that the commands need to be run from a working copy?
i must aaacept the chaaange Co-authored-by: Sam Clarke-Green <[email protected]>
these are not the docs we're looking for.... Co-authored-by: Sam Clarke-Green <[email protected]>
r-sharp
requested review from
cameronbateman-mo
and removed request for
ericaneininger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths in the working practices to find update_all.py in $UMDIR/bin are no longer valid. So updating them to where a copy might exist.