Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add guidance for lfric_core revision #167

Merged
merged 3 commits into from
Apr 15, 2024
Merged

add guidance for lfric_core revision #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3afe8e2
add guidance for lfric_core revision
james-bruten-mo Apr 15, 2024
06d91e3
back out contents change
james-bruten-mo Apr 15, 2024
a61e31b
updates from review
james-bruten-mo Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/WorkingPractices/TestSuites/lfric_apps.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ LFRic Apps testing is run with the following commands from a working copy:
-----

.. important::

When specifying the lfric_core source the lfric_core revision **must** be updated in ``dependencies.sh``.

* If setting the source to an fcm URL, the mirror needs to be used and the revision can either be blank (for latest commit) or any valid revision for that branch.
* If setting the source to a Working Copy, the hostname needs to be provided (as Hostname:Path) and the revision must be blank.

The LFRic Apps rose stem includes a range of tests to exercise all the applications
stored in this repository, using multiple compilers, and checksum and plot tasks to
confirm the outputs.
Expand Down
14 changes: 7 additions & 7 deletions source/WorkingPractices/multi_repository.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@ code revisions are needed for testing across repositories as described above.
Testing changes in JULES, LFRic Core, UKCA, or any other child repositories is
as simple as running the standalone test procedures for these codebases.

.. important::

When specifying an alternative source in the ``dependencies.sh`` file the revision for the source **must** be updated.

* If setting the source as an fcm URL, the mirror needs to be used and the revision can either be blank (for latest commit) or any valid revision for that branch.
* If setting the source as a Working Copy, the hostname needs to be provided (as Hostname:Path) and the revision must be blank.

Testing the UM with other repositories
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down Expand Up @@ -131,13 +138,6 @@ these paths can either be to local changes or those in the repository.
More details on LFRic Apps testing are found :ref:`here<lfric_apps_test>`.



.. tip::
Links to changes stored in fcm source control should point at the mirror
repository (note `jules.xm` rather than `jules.x` above). Links to local
changes provided to the LFRic Apps build should start with `<hostname>:`.

.. note::
If any of the testing shows up failures then there are two possible ways to
proceed:
Expand Down