Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Fab support environment variables? #332

Open
hiker opened this issue Jul 31, 2024 · 1 comment
Open

Should Fab support environment variables? #332

hiker opened this issue Jul 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@hiker
Copy link
Collaborator

hiker commented Jul 31, 2024

While supporting environment variables is a valid suggestion (for backwards compatibility with UKMO builds), imho Fab itself should NOT use environment variables to define compiler, linker, or flags.

First of all, this can cause test failures (if environment variables add flags to compiler calls). Second of all, it can be very counterintuitive and hard to debug if Fab is used for other software.

Instead, the scripting layer on top of Fab can (If required) support this. We already do this in our LFRic builds, our command-line tool (where you can define compiler etc) will default to the corresponding environment variable, and define the corresponding compiler.

Similarly, if required, the zero-config command line interface to Fab could query the variables and trigger the corresponding settings (if we really desire that).

@hiker hiker added the question Further information is requested label Jul 31, 2024
@hiker
Copy link
Collaborator Author

hiker commented Oct 14, 2024

We agreed to remove the support for this, and move the support for this into the command line interface (for zero config usages)

@hiker hiker added enhancement New feature or request and removed question Further information is requested labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant