UMPD3 checker: Check external repositories when they are modified by a branch. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyhickson
requested review from
a team,
ericaneininger and
james-bruten-mo
and removed request for
a team
james-bruten-mo
approved these changes
Sep 4, 2024
|
Can I give this PR a bump? |
ericaneininger
requested changes
Nov 8, 2024
ericaneininger
requested changes
Nov 8, 2024
ericaneininger
approved these changes
Nov 8, 2024
james-bruten-mo
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, UM dependencies are checked by the UMDP3 checker on the trunk.
However, in a branch, the branch diff is used rather than the source files themselves. (This means the script only checks things that are changed by a branch, not the entire source tree.)
This in turn means changes from the other dependencies are not checked until after they are on trunk in a linked ticket. (This is because the branch diff contains only the changes to the sources, not the code changes themselves - which exist in a different repository.)
This pull request modifies the script to ensure dependencies are checked with the branch, when the script identifies that either the
rose-suite.conffile, or theHOST_SOURCEenvironment variables have been modified. In that case, it inspects the full source of the external repository, as it would do on trunk.