Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve transect title #829

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Improve transect title #829

merged 8 commits into from
Nov 4, 2024

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Sep 13, 2024 •
edited
Loading

Include coordinate start/end information in title in transects. Links #811

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 added the enhancement New feature or request label Sep 13, 2024
@jwarner8 jwarner8 self-assigned this Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Coverage

@jwarner8 jwarner8 marked this pull request as ready for review November 4, 2024 15:42
jfrost-mo
jfrost-mo approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor nits but don't block merge.

src/CSET/operators/plot.py Outdated Show resolved Hide resolved
src/CSET/operators/transect.py Outdated Show resolved Hide resolved
@jwarner8 jwarner8 merged commit df53dd7 into main Nov 4, 2024
8 checks passed
@jwarner8 jwarner8 deleted the transect_titleinfo branch November 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees

@jwarner8 jwarner8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwarner8 @jfrost-mo