Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LFRic specific recipes now recipes can handle both UM and LFRic data #805

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Aug 20, 2024

They have all been replaced my the more generic version that work for both the UM and LFRic.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo added the cleanup Non-functional improvement label Aug 20, 2024
@jfrost-mo jfrost-mo self-assigned this Aug 20, 2024
@jfrost-mo jfrost-mo changed the title Remove unneeded recipes Remove LFRic specific recipes now recipes can handle both UM and LFRic data Aug 20, 2024
@jfrost-mo jfrost-mo marked this pull request as ready for review August 20, 2024 10:51
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Coverage

They have all been replaced my the more generic version that work for
both the UM and LFRic.
@jfrost-mo jfrost-mo merged commit adc35e1 into main Aug 22, 2024
7 checks passed
@jfrost-mo jfrost-mo deleted the remove_unneeded_recipes branch August 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants