Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of float in workflow #802

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Parsing of float in workflow #802

merged 1 commit into from
Aug 19, 2024

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Aug 19, 2024

Parsing a float into the workflow to generate the task name causes errors, as a period is not an acceptable character in the cylc workflow. This change parses the dot into a p for the workflow task names.

There might be a more general solution we could apply though, as I expect this might crop up with other diagnostics/variable combinations in new recipes.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 self-assigned this Aug 19, 2024
@jwarner8 jwarner8 added the bug Something isn't working label Aug 19, 2024
Copy link
Contributor

Coverage

Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A more general fix will come as part of the data time cycling, but this looks good for the current issue.

@jfrost-mo jfrost-mo merged commit 0578c9b into main Aug 19, 2024
7 checks passed
@jfrost-mo jfrost-mo deleted the parsing_decimals branch August 19, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants