Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net5 Implementation #3

Open
robfox92 opened this issue Jun 3, 2021 · 2 comments
Open

net5 Implementation #3

robfox92 opened this issue Jun 3, 2021 · 2 comments

Comments

@robfox92
Copy link

robfox92 commented Jun 3, 2021

Hi there, I've forked the project started porting it to net5.

What are your thoughts on bringing this project to net5? Do you think it's worth doing in one repository? Or is it best kept separate?

I was also wondering what your thoughts were around publishing a nuget package.

Cheers

@Matthew1471
Copy link
Owner

Matthew1471 commented Jun 5, 2021

Interesting, I'd been so tied up with maintaining existing applications at work I hadn't even realised there was a .NET 5!

I've researched and found:

"Additionally, we wanted to clearly communicate that .NET 5 is the future for the .NET platform."
https://devblogs.microsoft.com/dotnet/introducing-net-5/

I think given .NET 5 is the future, this library hasn't had a lot of usage yet (I haven't finished the class walker for WebClient) and people can always retarget older frameworks for their needs it makes sense to adopt .NET 5.

Thanks will give it a go and commit.

@robfox92
Copy link
Author

robfox92 commented Jun 7, 2021

I've made a partial go here, the main incompatibility was with the App.config files, and System.Web has been deprecated. Fortunately, the HttpUtility class has been renamed WebUtility and is still available.

I've not ported the config file changes, but it's on my todo list. I'll make a PR with the changes when I've done that, which should be over the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants