Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color #12

Open
SumZer0-git opened this issue May 3, 2022 · 5 comments
Open

Color #12

SumZer0-git opened this issue May 3, 2022 · 5 comments
Labels
question Further information is requested

Comments

@SumZer0-git
Copy link

I use the default Colors in ED. Was thinking to load all the template images and convert to gray scale
image = cv2.cvtColor(image, cv2.COLOR_GRAY2RGB)

Then when grabbing screen captures, to convert that to gray scale also and attempt template matching that way.

This way a user does not have to adjust their ED color scheme.

Thoughts?
(also nice work on the key bindings)

@Matrixchung
Copy link
Owner

Maybe I have tried it before, but in that way it will be extremely difficult to recognize compass circle when the ship's cockpit is bathing in sunlight :(
The navpoint dot will mess up under bright light
Given that problem, I was thinking of tuning the UI to a color (such as green) which makes a complete contrast with ambient light, but was not sure if this works.

@SumZer0-git
Copy link
Author

yes, I ran into the console being washed out by the Star. In doing jumping between systems, if you Pitch up over the Star then the Star is beneath the Ship and does not wash out the compass. However, there is still cases when maneuvering to the target where the Star shines into the cockpit (if the next Target is to the left or right of the Star and not behind it)

@Matrixchung
Copy link
Owner

That's where the problem is.
In normal cases, we will do sunAvoiding between jumps, but in some rare situations when we perform in-system supercruise, there's a chance of running into bright sunlight.

@Matrixchung
Copy link
Owner

I am wondering that if the problem is unavoidable, should we pitch up again for some secs then?
Or is there any solution to it

@SumZer0-git
Copy link
Author

yep, not sure easy solution. Thanks for feedback.

@Matrixchung Matrixchung added the question Further information is requested label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants