New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplfy checking for patterns #1088

Merged

rocky merged 1 commit into master from remove-one-more-pattern-codesmell

Sep 19, 2024

Member

rocky commented Sep 19, 2024

Replace pat.get_head_name() == "SystemPattern"with isinstance(pat, Pattern)`.

I think there are other places where we are using get_head_name() == "System`xxx but that is left for a different time.


          Simplfy checking for patterns

58e9def

Replace `pat.get_head_name() == "System`Pattern"` with isinstance(pat, Pattern)

mmatera approved these changes

View reviewed changes

Contributor

mmatera left a comment

LGTM

rocky merged commit b4bcc68 into master

11 checks passed

rocky deleted the remove-one-more-pattern-codesmell branch

September 19, 2024 16:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet