-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old setup.py in new release (also scikit-image as optional requirement) #944
Comments
The reason this is not optional was because tests were failing without this. Rather than go back and make it optional in say a 6.0.5, I think it better to wait for 7.0.0 go come out sometime in January when it will be optional again. Or use, in your distribution, a modified 6.0.3 or 6.0.4. |
Understood. I'll keep packaging it for AUR as is, for the time being, since it'd be too much hassle to patch it if there're otherwise some test failing. I hope it becomes lighter again soon by making scikit-image optional as before then. |
@vicp74 7.0.0 was released a while ago. Is this still a problem? |
@rocky this is not a problem anymore. I missed the fact that scikit-image is optional again, so I updated the AUR package accordingly. IMO this issue can be closed. |
@vicp74 Thanks for maintaining and updating the AUR package. |
Description
The tar.gz for release 6.0.4 includes the old version of
setup.py
, as it was in 6.0.3.Additional context
I noticed this because
scikit-image
was added as a install requirement during release 6.0.3 at line 44 of setup.py. Then, for the next release it was silently dropped from setup.py. Since I would like to keepscikit-image
as optional (because it's heavy, I don't work with images, etc...) I would like to use this opportunity to ask what is the intended behaviour.The text was updated successfully, but these errors were encountered: