Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old setup.py in new release (also scikit-image as optional requirement) #944

Closed
vicp74 opened this issue Dec 4, 2023 · 5 comments
Closed

Comments

@vicp74
Copy link

vicp74 commented Dec 4, 2023

Description

The tar.gz for release 6.0.4 includes the old version of setup.py, as it was in 6.0.3.

Additional context

I noticed this because scikit-image was added as a install requirement during release 6.0.3 at line 44 of setup.py. Then, for the next release it was silently dropped from setup.py. Since I would like to keep scikit-image as optional (because it's heavy, I don't work with images, etc...) I would like to use this opportunity to ask what is the intended behaviour.

@rocky
Copy link
Member

rocky commented Dec 6, 2023

setup.py is correct, the SHA1 tag for it however was not correct. The correct SHA1 is b0b7efe and the release tag has been corrected.

The reason this is not optional was because tests were failing without this. Rather than go back and make it optional in say a 6.0.5, I think it better to wait for 7.0.0 go come out sometime in January when it will be optional again. Or use, in your distribution, a modified 6.0.3 or 6.0.4.

@vicp74
Copy link
Author

vicp74 commented Dec 7, 2023

Understood. I'll keep packaging it for AUR as is, for the time being, since it'd be too much hassle to patch it if there're otherwise some test failing. I hope it becomes lighter again soon by making scikit-image optional as before then.

@rocky
Copy link
Member

rocky commented Oct 20, 2024

@vicp74 7.0.0 was released a while ago. Is this still a problem?

@vicp74
Copy link
Author

vicp74 commented Oct 28, 2024

@rocky this is not a problem anymore. I missed the fact that scikit-image is optional again, so I updated the AUR package accordingly. IMO this issue can be closed.

@vicp74 vicp74 closed this as completed Oct 28, 2024
@rocky
Copy link
Member

rocky commented Oct 28, 2024

@vicp74 Thanks for maintaining and updating the AUR package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants