Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues to address before 6.0.0 release #681

Open
17 of 18 tasks
rocky opened this issue Dec 24, 2022 · 3 comments
Open
17 of 18 tasks

Issues to address before 6.0.0 release #681

rocky opened this issue Dec 24, 2022 · 3 comments

Comments

@rocky
Copy link
Member

rocky commented Dec 24, 2022

  • Import["ExampleData/MadTeaParty.gif"] is broken
  • Show SciPy version (or non) under version info (and in Django)
  • (Django) Go over gallery examples, possibly add new stuff. color boxes are too small
  • Asymptote axes for Plot are misaligned possibly now that they are aligned for SVG
  • LaTeX doc rendering of Asymptote graphs is misaligned. Go over LaTeX doc for content
  • Remove Combinatorica error in trying to redefine CatalanNumber
  • Replace all methods named apply which are really eval methods?
  • Remove acceptance of apply in the contribute() function?
  • Finish removing "miscellaneous" List functions.
  • Many Mathics3 Modules builtins docstrings don't have WMA links
  • Organize Mathics3 Modules graph and natlang into sections like we do for builtins with suitable names
  • Add doctests (docpipeline.py) for pymathics modules - sort of along the lines of what we do for Mathics-Django. However testing should only be done of the Mathics3 Modules3 module that is getting added
  • Add minimal set of pytests for Mathics3 Modules. I have started some work here in pymathics.graph.
  • Build LaTeX PDF with Mathics3 Modules natlang and graph included.
  • Add Gallery and Mathics Doc Demo examples for Mathics3 Modules
  • One more dockerhub release beforehand to make sure this works.
  • Max Recursion with CPython when Flat attributes are present Max Recursion in Flat attribute testing using CPython #736
  • Go over CHANGES.rst (which is really part of the release itself.

For the release, Mathics3 Modules don't have to be perfect, just good enough to show that they exist so that users start to realize that they are there . Mathics3 Modules can be improved after release, but we should ensure that we are not likely to need another API change in this area.

The docs just should have a reasonable organization and information like we do for Built-ins. Having something that is obviously shoddy when it is a simple matter to correct this, doesn't encourage participation or use of Mathics3 Modules. So again the goal is "not obviously shoddy" using an API that won't likely need changing so soon again.

@rocky
Copy link
Member Author

rocky commented Dec 31, 2022

@mmatera - in going over documentation bugs, I am seeing really weird behavior that seems boxing related that has occurred since the last release. I hope you can help with this:

If you look at the output in Django for:

Graphics[{Text["First", {0, 0}], Text["Second", {1, 1}]}, Axes->True, PlotRange->{{-2, 2}, {-2, 2}}]

The quotes around the labels "First" and "Second".

Or showing the first part of this in TeXForm:

In[1]:= Graphics[{Text["First", {0, 0}], Text["Second", {1, 1}]}, Axes->True, PlotRange->{{-2, 2}, {-2, 2}}] // TeXForm
Out[1]//TeXForm= 
                 \begin{asy}
                 usepackage("amsmath");
                 size(5.8333cm, 5.8333cm);
                 // InsetBox
                 label("$\text{"First"}$", (175.0,175.0), (0,0), rgb(0, 0, 0));
   ...

If you compare with the last release and the docs page 146 of https://mathics.org/docs/mathics-latest.pdf you will see that quotes do not appear there.

If we can't figure this out, by other means I can do a git bisect to find which commit caused this problem.

@mmatera
Copy link
Contributor

mmatera commented Dec 31, 2022

Ok. Let me check

@mmatera
Copy link
Contributor

mmatera commented Dec 31, 2022

If the quotes appear or not is controlled in mathis.format.latex.string. Let me check why now they appear in graphics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants