Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding MPRIS #433

Open
fijar-lazuardy opened this issue Jul 8, 2024 · 8 comments
Open

Question regarding MPRIS #433

fijar-lazuardy opened this issue Jul 8, 2024 · 8 comments
Labels
bug Something isn't working Can't reproduce

Comments

@fijar-lazuardy
Copy link

If I play a video, tidal will shown as "chromium.instance" instead of "tidal-hifi" is it a bug?

@Mastermindzh Mastermindzh added the bug Something isn't working label Jul 10, 2024
@Mastermindzh
Copy link
Owner

Hey @fijar-lazuardy,

Yes it is.
We've been having a hard time removing "chromium.instance" and other chromium-related names in various places.
Removing it often means disabling parts of the browser as well, which would have adverse affects on the player.

I'll have a look when I can to see if this one is an easy fix though.

@fijar-lazuardy
Copy link
Author

no worries, it's not bothering or anything

@Mastermindzh Mastermindzh added cantfix Problem that we can't fix bug Something isn't working Can't reproduce and removed bug Something isn't working cantfix Problem that we can't fix labels Jul 15, 2024
@Mastermindzh
Copy link
Owner

@fijar-lazuardy

I just checked and it works as expected. I can successfully play/pause media using:

playerctl play-pause tidal-hifi to play and pause the videos.

I also found the following:

  • playerctl -l doesn't always seem to list tidal-hifi, but even if not listed it does still work
  • when you start tidal with a video preloaded, the addMpris function doesn't seem to execute, gotta look into that (bug)

Please tell me the steps you used to identify this 😄

@Mastermindzh
Copy link
Owner

the addMpris function does set up a player but it isn't hooked up to the video player. That seems to be a TIDAL thingy for now but might be fixed with the new API.

For now there doesn't seem to be anything I can do.

@fijar-lazuardy
Copy link
Author

Nice to hear and thanks for checking this! I'll try when I get home and put the result here

@fijar-lazuardy
Copy link
Author

System
OS: Linux Mint 21.3 x86_64
Kernel: 5.15.0-91-generic
Packages: 2185 (dpkg)
Shell: zsh 5.8.1
DE: Xfce 4.18
WM: Xfwm4
Terminal: kitty
CPU: AMD Ryzen 7 5700X3D (16) @ 3.000GHz
GPU: AMD ATI 2d:00.0 Device 73ef
Memory: 6903MiB / 32012MiB
tidal-hifi version: 5.14.1

case 1:
image

playerctl -l

play video and run

playerctl -l

again does not update MPRIS
image

case 2:
play video right after tidal opened
image

@Mastermindzh
Copy link
Owner

Ah!

I didn't check wether metadata is updated.... I only checked controls (e.g. play).
It makes way more sense that the data wouldn't be updated correctly though (I never looked at video support)

Thanks for the testing!

@mitteneer
Copy link

Somewhat unrelated, but this will also happen on occasion as I'm skipping songs - often it will correctly begin as tidal-hifi, but after some skipping, my statusbar which uses playerctl to track tidal-hifi will stop updating (I also stop receiving notifications from dunst) and using playerctl afterwards will still list tidal-hifi, but with the metadat of some previous song, whereas there will some chromium instance which lists the actual current song. Not certain if this occurs only while I skip songs, or if it happens naturally during track progression. Sometimes it will correct itself, but not certain how to cause "corrections" on demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Can't reproduce
Projects
None yet
Development

No branches or pull requests

3 participants