Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove switch statement for ProcessJobConsumer #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove switch statement for ProcessJobConsumer #2

wants to merge 1 commit into from

Conversation

shahabganji
Copy link

Dear @phatboyg

I was reading this sample and saw the following:

Not too sure how I feel about the enum indicating what batch action to take, and then the switch statement in the ProcessJobConsumer where it conditionally creates the routing slip activity. Is there a more elegant way? I'll need to think about that.

Based on what I read here and here. I used the SmartEnum library to tackle this problem.

I am not sure whether I changed it in an elegant way or not, so please let me know your opinion.

Thanks.

@shahabganji shahabganji force-pushed the master branch 2 times, most recently from 48c6aa3 to b6649b7 Compare July 20, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shahabganji