Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure an itp generated w/ dssp when using the --bias_auto flag #14

Open
sebtha opened this issue Sep 20, 2023 · 2 comments
Open

Ensure an itp generated w/ dssp when using the --bias_auto flag #14

sebtha opened this issue Sep 20, 2023 · 2 comments

Comments

@sebtha
Copy link
Collaborator

sebtha commented Sep 20, 2023

There is no check if the itp was generated using dssp or another secondary structure assignment. If neither was used, line 5 contains the Martini 3 citation which contains a few "C" and "H", where then additional interactions are added to the respective BB beads.

It should be reasonable to check the usage of dssp in get_ss.

@Lp0lp
Copy link
Contributor

Lp0lp commented Sep 21, 2023

Excellent point! I did not think of this! I can have a look!
In this case, would it also be interesting/of use to have an option to allow the user to enter a secondary structure assignment string manually?

@sebtha
Copy link
Collaborator Author

sebtha commented Sep 26, 2023

In my opinion, this (i.e., the manually added secondary structure assignment) is not necessary from a physical point of view. The manually supplied string for the secondary structure assignment is noted in the same line as the dssp assignment in the protein.itp file by martinize2, which makes our lifes here easy.

In terms of flexibility, testing and fine-tuning, however, it might be a good option. But not urgent for now in my view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants