Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Investigate flaky check_repo_permissions test #7227

Closed
wants to merge 4 commits into from
Closed

[DRAFT] Investigate flaky check_repo_permissions test #7227

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ce0cfa
Test
david-yz-liu Sep 25, 2024
b61a086
Add SQL statement to test (for debugging)
david-yz-liu Sep 26, 2024
2fcd624
More debugging on the test
david-yz-liu Sep 27, 2024
246f07c
Add more debugging columns
david-yz-liu Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions spec/db/check_repo_permissions_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,32 @@

context 'the due date has not passed' do
it 'should fail' do
expect(grouping.assignment.reload.is_timed).to be_truthy
expect(grouping.assignment.reload.due_date).to be > Time.current
expect(grouping.reload.start_time).to be_nil
results = Membership.connection.select_all("
SELECT roles.id, assignment_properties.is_timed, groupings.start_time, assessments.due_date, NOW()
FROM memberships
JOIN roles ON roles.id=memberships.role_id
JOIN groupings ON memberships.grouping_id=groupings.id
JOIN groups ON groupings.group_id=groups.id
JOIN assignment_properties ON assignment_properties.assessment_id=groupings.assessment_id
JOIN assessments ON groupings.assessment_id=assessments.id
JOIN courses ON assessments.course_id=courses.id
LEFT OUTER JOIN assessment_section_properties ON assessment_section_properties.assessment_id=assessments.id
WHERE memberships.type='StudentMembership'
AND memberships.membership_status IN ('inviter','accepted')
AND assignment_properties.vcs_submit=true
AND roles.id='#{role.id}'
AND courses.is_hidden=false
AND groups.repo_name='#{grouping.group.repo_name}'
AND ((assessment_section_properties.is_hidden IS NULL AND assessments.is_hidden=false)
OR assessment_section_properties.is_hidden=false)
AND (assignment_properties.is_timed=false
OR groupings.start_time IS NOT NULL
OR (groupings.start_time IS NULL AND assessments.due_date<NOW()))
")
expect(results).to be_empty
expect(script_success?).to be_falsy
end
end
Expand Down
Loading