Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: increase flaky test coverage for course model #6667

Merged

Conversation

pretendWhale
Copy link
Contributor

@pretendWhale pretendWhale commented Jul 10, 2023

Motivation and Context

Due to non-deterministic ordering, coveralls reports that some lines are not covered. This PR aims to fix that by sorting the order of expected results rather than using if statements to concatenate them.

Your Changes

Description:
Updated course_spec.rb tests that coveralls was reporting as not tested to remove if statements.

Type of change (select all that apply):

  • Test update (change that modifies or updates tests only)

Testing

Ran the new tests.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

Pull request to make documentation changes (if applicable)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5513803615

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 91.695%

Totals Coverage Status
Change from base Build 5495942098: 0.007%
Covered Lines: 37132
Relevant Lines: 39960

💛 - Coveralls

Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pretendWhale!

@david-yz-liu david-yz-liu merged commit b9311ba into MarkUsProject:master Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants