MDBF 633: Docker compose file example for MySQL 5.7 migration #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an3l
force-pushed
the
anel-mysql57-migration
branch
from
1e69500
to
214333c
Compare
grooverdan
reviewed
Jan 12, 2024
| environment: | ||
| <<: *common-variables | ||
| MARIADB_AUTO_UPGRADE: 1 | ||
| container_name: ${MYSQL_MIGRATE_name} |
There was a problem hiding this comment.
where is MYSQL_MIGRATE_name from?
There was a problem hiding this comment.
Why not MARIADB_ROOT_PASSWORD and the other alternative MARIADB_ env vars?
| services: | ||
| mariadb-from-mysql57: | ||
| environment: | ||
| <<: *common-variables |
There was a problem hiding this comment.
common variables aren't used when there's an upgrade. Remove?
an3l
force-pushed
the
anel-mysql57-migration
branch
from
214333c
to
dd974d0
Compare
an3l
force-pushed
the
anel-mysql57-migration
branch
from
dd974d0
to
fb07772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.